neighbor: Remove state and flags arguments to neigh_del
authorDavid Ahern <dsahern@gmail.com>
Wed, 12 Dec 2018 01:57:23 +0000 (18:57 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 14 Dec 2018 23:44:47 +0000 (15:44 -0800)
neigh_del now only has 1 caller, and the state and flags arguments
are both 0. Remove them and simplify neigh_del.

Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/neighbour.c

index acaa1a64150de9a000a92bf89c2ae5bff42af128..bb6f9ca7a3cea63501faa05c829437989874bb30 100644 (file)
@@ -153,14 +153,13 @@ static void neigh_update_gc_list(struct neighbour *n)
        write_unlock_bh(&n->tbl->lock);
 }
 
-static bool neigh_del(struct neighbour *n, __u8 state, __u8 flags,
-                     struct neighbour __rcu **np, struct neigh_table *tbl)
+static bool neigh_del(struct neighbour *n, struct neighbour __rcu **np,
+                     struct neigh_table *tbl)
 {
        bool retval = false;
 
        write_lock(&n->lock);
-       if (refcount_read(&n->refcnt) == 1 && !(n->nud_state & state) &&
-           !(n->flags & flags)) {
+       if (refcount_read(&n->refcnt) == 1) {
                struct neighbour *neigh;
 
                neigh = rcu_dereference_protected(n->next,
@@ -192,7 +191,7 @@ bool neigh_remove_one(struct neighbour *ndel, struct neigh_table *tbl)
        while ((n = rcu_dereference_protected(*np,
                                              lockdep_is_held(&tbl->lock)))) {
                if (n == ndel)
-                       return neigh_del(n, 0, 0, np, tbl);
+                       return neigh_del(n, np, tbl);
                np = &n->next;
        }
        return false;