mmc: core: free mmc_card if cmd 3,9,7 fails in mmc_sd_init_card
authorWei WANG <wei_wang@realsil.com.cn>
Wed, 17 Jul 2013 06:21:10 +0000 (14:21 +0800)
committerChris Ball <cjb@laptop.org>
Sun, 25 Aug 2013 02:53:30 +0000 (22:53 -0400)
In function mmc_sd_init_card, if command 3/9/7 got failed, mmc_card
allocated just before won't be freed. This would cause memory leak.

Signed-off-by: Wei WANG <wei_wang@realsil.com.cn>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/core/sd.c

index 176d125f5b577c697f90396b0243258977239548..1240a85a9aa2822aae24e15a57459ab9453b5aa1 100644 (file)
@@ -942,13 +942,13 @@ static int mmc_sd_init_card(struct mmc_host *host, u32 ocr,
        if (!mmc_host_is_spi(host)) {
                err = mmc_send_relative_addr(host, &card->rca);
                if (err)
-                       return err;
+                       goto free_card;
        }
 
        if (!oldcard) {
                err = mmc_sd_get_csd(host, card);
                if (err)
-                       return err;
+                       goto free_card;
 
                mmc_decode_cid(card);
        }
@@ -959,7 +959,7 @@ static int mmc_sd_init_card(struct mmc_host *host, u32 ocr,
        if (!mmc_host_is_spi(host)) {
                err = mmc_select_card(card);
                if (err)
-                       return err;
+                       goto free_card;
        }
 
        err = mmc_sd_setup_card(host, card, oldcard != NULL);