nfs41: do not return ENOMEM on LAYOUTUNAVAILABLE
authorTigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Tue, 16 Jan 2018 21:38:50 +0000 (22:38 +0100)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Thu, 18 Jan 2018 17:51:31 +0000 (12:51 -0500)
A pNFS server may return LAYOUTUNAVAILABLE error on LAYOUTGET for files
which don't have any layout. In this situation pnfs_update_layout
currently returns NULL. As this NULL is converted into ENOMEM, IO
requests fails instead of falling back to MDS.

Do not return ENOMEM on LAYOUTUNAVAILABLE and let client retry through
MDS.

Fixes 8d40b0f14846f. I will suggest to backport this fix to affected
stable branches.

Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
[trondmy: Use IS_ERR_OR_NULL()]
Fixes: 8d40b0f14846 ("NFS filelayout:call GETDEVICEINFO after...")
Cc: stable@vger.kernel.org # v4.11+
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
fs/nfs/filelayout/filelayout.c

index 4e54d8b5413a86fe83fe7be2f93209521bd49032..d175724ff566bf9a5525239a4aedb5308353f6b3 100644 (file)
@@ -895,9 +895,7 @@ fl_pnfs_update_layout(struct inode *ino,
 
        lseg = pnfs_update_layout(ino, ctx, pos, count, iomode, strict_iomode,
                                  gfp_flags);
-       if (!lseg)
-               lseg = ERR_PTR(-ENOMEM);
-       if (IS_ERR(lseg))
+       if (IS_ERR_OR_NULL(lseg))
                goto out;
 
        lo = NFS_I(ino)->layout;