watchdog: make watchdog_deferred_registration_add() void
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 18 May 2019 21:27:16 +0000 (23:27 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 8 Jul 2019 13:13:01 +0000 (15:13 +0200)
It cannot fail, so no return value needed.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/watchdog_core.c

index 62be9e52a4deaa30427fcb99ecee3ba899b2f4ce..9fd096af0cc5fc949edaa12cc80b3dd656f505be 100644 (file)
@@ -60,11 +60,10 @@ static DEFINE_MUTEX(wtd_deferred_reg_mutex);
 static LIST_HEAD(wtd_deferred_reg_list);
 static bool wtd_deferred_reg_done;
 
-static int watchdog_deferred_registration_add(struct watchdog_device *wdd)
+static void watchdog_deferred_registration_add(struct watchdog_device *wdd)
 {
        list_add_tail(&wdd->deferred,
                      &wtd_deferred_reg_list);
-       return 0;
 }
 
 static void watchdog_deferred_registration_del(struct watchdog_device *wdd)
@@ -265,13 +264,13 @@ static int __watchdog_register_device(struct watchdog_device *wdd)
 
 int watchdog_register_device(struct watchdog_device *wdd)
 {
-       int ret;
+       int ret = 0;
 
        mutex_lock(&wtd_deferred_reg_mutex);
        if (wtd_deferred_reg_done)
                ret = __watchdog_register_device(wdd);
        else
-               ret = watchdog_deferred_registration_add(wdd);
+               watchdog_deferred_registration_add(wdd);
        mutex_unlock(&wtd_deferred_reg_mutex);
        return ret;
 }