drm/i915: Rework __i915_gem_shrink
authorBen Widawsky <ben@bwidawsk.net>
Thu, 1 Aug 2013 00:00:01 +0000 (17:00 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 8 Aug 2013 12:02:41 +0000 (14:02 +0200)
In order to do this for all VMs, it's convenient to rework the logic a
bit. This should have no functional impact.

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem.c

index 3debb35b7195d7fd623c370aac67d6a8487078de..4ca8f9fad913536c415bfbdc200df07d77063a65 100644 (file)
@@ -1707,9 +1707,14 @@ __i915_gem_shrink(struct drm_i915_private *dev_priv, long target,
        }
 
        list_for_each_entry_safe(obj, next, &vm->inactive_list, mm_list) {
-               if ((i915_gem_object_is_purgeable(obj) || !purgeable_only) &&
-                   i915_gem_object_unbind(obj) == 0 &&
-                   i915_gem_object_put_pages(obj) == 0) {
+
+               if (!i915_gem_object_is_purgeable(obj) && purgeable_only)
+                       continue;
+
+               if (i915_gem_object_unbind(obj))
+                       continue;
+
+               if (!i915_gem_object_put_pages(obj)) {
                        count += obj->base.size >> PAGE_SHIFT;
                        if (count >= target)
                                return count;