ASoC: rt286: don't turn off HV and VREF if headset is detected
authorBard Liao <bardliao@realtek.com>
Mon, 19 Mar 2018 10:07:12 +0000 (18:07 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 20 Mar 2018 01:02:06 +0000 (09:02 +0800)
"HV" and "VREF" will be powered up when jack type detection process is
started and will be powered off when jack type detection process is finished.
It will generate an unexpected interrupt signal when they are powered
up during the capture process. Codec driver will do the jack type detection
process and we can't capture properly before the jack detection process is
finished. This patch will not power off the "HV" and "VREF" widgets if
headset is detected and it will solve the unexpected interrupt issue. As a
result, it will also solve the silence data captured at the beginning in
headset mic recording issue.

Signed-off-by: Bard Liao <bardliao@realtek.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt286.c

index af6325c78292d2e49eae9021887d437b9aac9e22..e5c9d59c3967b4bb442d82ee016f8eb478e7446f 100644 (file)
@@ -275,9 +275,10 @@ static int rt286_jack_detect(struct rt286_priv *rt286, bool *hp, bool *mic)
                regmap_read(rt286->regmap, RT286_GET_MIC1_SENSE, &buf);
                *mic = buf & 0x80000000;
        }
-
-       snd_soc_dapm_disable_pin(dapm, "HV");
-       snd_soc_dapm_disable_pin(dapm, "VREF");
+       if (!*mic) {
+               snd_soc_dapm_disable_pin(dapm, "HV");
+               snd_soc_dapm_disable_pin(dapm, "VREF");
+       }
        if (!*hp)
                snd_soc_dapm_disable_pin(dapm, "LDO1");
        snd_soc_dapm_sync(dapm);