bcache: Remove deprecated create_workqueue
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Tue, 7 Jun 2016 20:27:19 +0000 (01:57 +0530)
committerJens Axboe <axboe@fb.com>
Sun, 12 Jun 2016 02:03:04 +0000 (20:03 -0600)
alloc_workqueue replaces deprecated create_workqueue().

Dedicated workqueues have been used since bcache_wq and moving_gc_wq
are workqueues for writes and are being used on a memory reclaim path.
WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/md/bcache/super.c

index c944daf75dd000bdc1c5d5a64254f8e58d74bfc9..d542438b18df4efe5514516847faebe00863ef13 100644 (file)
@@ -1520,7 +1520,8 @@ struct cache_set *bch_cache_set_alloc(struct cache_sb *sb)
            !(c->fill_iter = mempool_create_kmalloc_pool(1, iter_size)) ||
            !(c->bio_split = bioset_create(4, offsetof(struct bbio, bio))) ||
            !(c->uuids = alloc_bucket_pages(GFP_KERNEL, c)) ||
-           !(c->moving_gc_wq = create_workqueue("bcache_gc")) ||
+           !(c->moving_gc_wq = alloc_workqueue("bcache_gc",
+                                               WQ_MEM_RECLAIM, 0)) ||
            bch_journal_alloc(c) ||
            bch_btree_cache_alloc(c) ||
            bch_open_buckets_alloc(c) ||
@@ -2099,7 +2100,7 @@ static int __init bcache_init(void)
                return bcache_major;
        }
 
-       if (!(bcache_wq = create_workqueue("bcache")) ||
+       if (!(bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0)) ||
            !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||
            sysfs_create_files(bcache_kobj, files) ||
            bch_request_init() ||