mtd: onenand: omap2: print resource using %pR format string
authorArnd Bergmann <arnd@arndb.de>
Tue, 16 Jan 2018 07:43:40 +0000 (08:43 +0100)
committerBoris Brezillon <boris.brezillon@free-electrons.com>
Tue, 16 Jan 2018 08:25:12 +0000 (09:25 +0100)
The omap2 onenand driver is now available for compile-testing, which
uncovers a warning in configurations that have a 64-bit resource_size_t:

drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe':
drivers/mtd/onenand/omap2.c:536:54: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
   dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
drivers/mtd/onenand/omap2.c:536:66: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]

Changing the format string to the special %pR simplifies the code
and lets it do the right thing in that configuration, while avoiding
the warning.

Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
drivers/mtd/onenand/omap2.c

index 2ce73fb6da1c31cd5cfbfaa9c9e59e1b9af85f3e..a4a2159bcfb7f51d9891ebfd5f5b29ce1f34d096 100644 (file)
@@ -533,8 +533,7 @@ static int omap2_onenand_probe(struct platform_device *pdev)
 
        c->onenand.base = devm_ioremap_resource(dev, res);
        if (IS_ERR(c->onenand.base)) {
-               dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
-                       res->start, resource_size(res));
+               dev_err(dev, "Cannot reserve memory region %pR\n", res);
                return PTR_ERR(c->onenand.base);
        }