serial: mctrl_gpio: use gpiod_set_array function
authorRojhalat Ibrahim <imr@rtschenk.de>
Mon, 17 Nov 2014 17:31:30 +0000 (18:31 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 2 Dec 2014 13:25:42 +0000 (14:25 +0100)
Make the serial_mctrl_gpio driver the first user of the new gpiod_set_array
function, which is now available in the linux-gpio devel tree.
All modem control output signals are now set simultaneously.

Signed-off-by: Rojhalat Ibrahim <imr@rtschenk.de>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/tty/serial/serial_mctrl_gpio.c

index a3035f997b98a27cf4cf291b0cb58a456abf0d57..a38596c5194e4b6f6a1feb26183e4b9cd8366f2f 100644 (file)
@@ -44,15 +44,21 @@ static const struct {
 void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
 {
        enum mctrl_gpio_idx i;
+       struct gpio_desc *desc_array[UART_GPIO_MAX];
+       int value_array[UART_GPIO_MAX];
+       unsigned int count = 0;
 
        if (IS_ERR_OR_NULL(gpios))
                return;
 
        for (i = 0; i < UART_GPIO_MAX; i++)
                if (!IS_ERR_OR_NULL(gpios->gpio[i]) &&
-                   mctrl_gpios_desc[i].dir_out)
-                       gpiod_set_value(gpios->gpio[i],
-                                       !!(mctrl & mctrl_gpios_desc[i].mctrl));
+                   mctrl_gpios_desc[i].dir_out) {
+                       desc_array[count] = gpios->gpio[i];
+                       value_array[count] = !!(mctrl & mctrl_gpios_desc[i].mctrl);
+                       count++;
+               }
+       gpiod_set_array(count, desc_array, value_array);
 }
 EXPORT_SYMBOL_GPL(mctrl_gpio_set);