media: staging: atomisp: remove an useless check

There's a check at ia_css_vf_configure() to verify if
binary is not null. However, this is called too late:
	drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c:133 ia_css_vf_configure() warn: variable dereferenced before check 'binary' (see line 129)

This test is wrong, as this fuction is only called by
ia_css_binary_fill_info(), in a place that already assumes that
binary is not null, and checks with:
	assert(binary != NULL);

So, remove the useless broken extra check.

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
index 5610833ed595d242f7311b428c4cd7c8820db4de..c2076e4124101d93386654789f8358c75f82fde8 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
@@ -130,11 +130,11 @@ ia_css_vf_configure(
 
        err = configure_kernel(info, out_info, vf_info, downscale_log2, &config);
        configure_dma(&config, vf_info);
-       if (binary) {
-               if (vf_info)
-                       vf_info->raw_bit_depth = info->dma.vfdec_bits_per_pixel;
-               ia_css_configure_vf (binary, &config);
-       }
+
+       if (vf_info)
+               vf_info->raw_bit_depth = info->dma.vfdec_bits_per_pixel;
+       ia_css_configure_vf (binary, &config);
+
        return IA_CSS_SUCCESS;
 }