Fix example error_injection_tool
authorXie XiuQi <xiexiuqi@huawei.com>
Fri, 29 Mar 2013 01:43:47 +0000 (09:43 +0800)
committerTony Luck <tony.luck@intel.com>
Tue, 2 Apr 2013 16:39:55 +0000 (09:39 -0700)
I got a "sched_setaffinity:: Invalid argument" error when using
err_injection_tool to inject error on a system with over 32 cpus.

Error information when injecting an error on a system with over 32 cpus:
$ ./err_injection_tool -i
/sys/devices/system/cpu/cpu0/err_inject//err_type_info
Begine at Tue Mar 26 11:20:08 2013
Configurations:
On cpu32: loop=10, interval=5(s) err_type_info=4101,err_struct_info=95
Error sched_setaffinity:: Invalid argument
All done

This because there is overflow when calculating the cpumask: the
type of (1<<k) is int, while mask[j] is unsigned long. When k > 31,
(1<<k) is truncated to ZERO, resulting in a unexpected cpumask.

Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Documentation/ia64/err_inject.txt

index 223e4f0582d018254e692b8e83d809fe77dbc400..9f651c181429052b06d1e331f112141f947c6f71 100644 (file)
@@ -882,7 +882,7 @@ int err_inj()
                        cpu=parameters[i].cpu;
                        k = cpu%64;
                        j = cpu/64;
-                       mask[j]=1<<k;
+                       mask[j] = 1UL << k;
 
                        if (sched_setaffinity(0, MASK_SIZE*8, mask)==-1) {
                                perror("Error sched_setaffinity:");