staging/android: remove pointless sync_timeline_signal at destroy phase
authorGustavo Padovan <gustavo.padovan@collabora.co.uk>
Thu, 21 Jan 2016 12:49:23 +0000 (10:49 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Feb 2016 01:34:58 +0000 (17:34 -0800)
All changes to timeline value come through the user via
sync_timeline_signal() calls. When sync_timeline_destroy() is called no
changes on timeline->value happens hence call sync_timeline_signal() with
no increment is pointless.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/sync.c

index 9ec55ef16eb1c900a3e2e1b77f6410e0fac77a64..b9f167ffdff5e7576e9d54fbc6c4f0de22bce0de 100644 (file)
@@ -90,10 +90,6 @@ void sync_timeline_destroy(struct sync_timeline *obj)
         */
        smp_wmb();
 
-       /*
-        * signal any children that their parent is going away.
-        */
-       sync_timeline_signal(obj);
        sync_timeline_put(obj);
 }
 EXPORT_SYMBOL(sync_timeline_destroy);