rcu: Make srcu_read_lock_held() call common lockdep-enabled function
authorPaul E. McKenney <paul.mckenney@linaro.org>
Fri, 7 Oct 2011 16:22:05 +0000 (18:22 +0200)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Sun, 11 Dec 2011 18:31:34 +0000 (10:31 -0800)
A common debug_lockdep_rcu_enabled() function is used to check whether
RCU lockdep splats should be reported, but srcu_read_lock() does not
use it.  This commit therefore brings srcu_read_lock_held() up to date.

Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
include/linux/srcu.h

index 4e0a3d41dae3a4da2071eb3fceff4f7eae5d1639..d4b12443b2efd8c75a83e5c51b7783a60a220cb6 100644 (file)
@@ -84,6 +84,9 @@ long srcu_batches_completed(struct srcu_struct *sp);
  * this assumes we are in an SRCU read-side critical section unless it can
  * prove otherwise.
  *
+ * Checks debug_lockdep_rcu_enabled() to prevent false positives during boot
+ * and while lockdep is disabled.
+ *
  * Note that if the CPU is in the idle loop from an RCU point of view
  * (ie: that we are in the section between rcu_idle_enter() and
  * rcu_idle_exit()) then srcu_read_lock_held() returns false even if
@@ -102,7 +105,7 @@ static inline int srcu_read_lock_held(struct srcu_struct *sp)
        if (rcu_is_cpu_idle())
                return 0;
 
-       if (!debug_locks)
+       if (!debug_lockdep_rcu_enabled())
                return 1;
 
        return lock_is_held(&sp->dep_map);