projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
50c4c4e
)
RISC-V: Logical vs Bitwise typo
author
Dan Carpenter
<dan.carpenter@oracle.com>
Sat, 9 Dec 2017 11:49:14 +0000
(14:49 +0300)
committer
Palmer Dabbelt
<palmer@dabbelt.com>
Mon, 11 Dec 2017 15:51:06 +0000
(07:51 -0800)
In the current code, there is a ! logical NOT where a bitwise ~ NOT was
intended. It means that we never return -EINVAL.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
arch/riscv/kernel/sys_riscv.c
patch
|
blob
|
history
diff --git
a/arch/riscv/kernel/sys_riscv.c
b/arch/riscv/kernel/sys_riscv.c
index a2ae936a093e4f91d4def96fff0dd46e6e0226c0..79c78668258ede202086c072c63352ca14585903 100644
(file)
--- a/
arch/riscv/kernel/sys_riscv.c
+++ b/
arch/riscv/kernel/sys_riscv.c
@@
-70,7
+70,7
@@
SYSCALL_DEFINE3(riscv_flush_icache, uintptr_t, start, uintptr_t, end,
bool local = (flags & SYS_RISCV_FLUSH_ICACHE_LOCAL) != 0;
/* Check the reserved flags. */
- if (unlikely(flags &
!
SYS_RISCV_FLUSH_ICACHE_ALL))
+ if (unlikely(flags &
~
SYS_RISCV_FLUSH_ICACHE_ALL))
return -EINVAL;
flush_icache_mm(mm, local);