net: phy: replace bool members in struct phy_device with bit-fields
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 23 May 2018 06:05:20 +0000 (08:05 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 May 2018 19:35:58 +0000 (15:35 -0400)
In struct phy_device we have a number of flags being defined as type
bool. Similar to e.g. struct pci_dev we can save some space by using
bit-fields.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/phy.h

index 073235e704427c3e1238f4cfed1a97574f8193b3..6cd09098427c5bcd93d58f1d842165c2b9ffe7c0 100644 (file)
@@ -406,13 +406,17 @@ struct phy_device {
        u32 phy_id;
 
        struct phy_c45_device_ids c45_ids;
-       bool is_c45;
-       bool is_internal;
-       bool is_pseudo_fixed_link;
-       bool has_fixups;
-       bool suspended;
-       bool sysfs_links;
-       bool loopback_enabled;
+       unsigned is_c45:1;
+       unsigned is_internal:1;
+       unsigned is_pseudo_fixed_link:1;
+       unsigned has_fixups:1;
+       unsigned suspended:1;
+       unsigned sysfs_links:1;
+       unsigned loopback_enabled:1;
+
+       unsigned autoneg:1;
+       /* The most recently read link state */
+       unsigned link:1;
 
        enum phy_state state;
 
@@ -429,9 +433,6 @@ struct phy_device {
        int pause;
        int asym_pause;
 
-       /* The most recently read link state */
-       int link;
-
        /* Enabled Interrupts */
        u32 interrupts;
 
@@ -444,8 +445,6 @@ struct phy_device {
        /* Energy efficient ethernet modes which should be prohibited */
        u32 eee_broken_modes;
 
-       int autoneg;
-
        int link_timeout;
 
 #ifdef CONFIG_LED_TRIGGER_PHY