net: cdc_ncm: use tasklet_init() for tasklet_struct init

The tasklet initialisation would be better done by tasklet_init()
instead of assuming all the fields are in an ok state by default.

This does not fix any actual know bug.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 1eaec648bd1f716db3d06622cdfb7834e64e4e38..35a7d61453d582c33634da8a1f1d5bd433a01f50 100644 (file)
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -779,8 +779,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct usb_interface *intf, u8 data_
 
        hrtimer_init(&ctx->tx_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
        ctx->tx_timer.function = &cdc_ncm_tx_timer_cb;
-       ctx->bh.data = (unsigned long)dev;
-       ctx->bh.func = cdc_ncm_txpath_bh;
+       tasklet_init(&ctx->bh, cdc_ncm_txpath_bh, (unsigned long)dev);
        atomic_set(&ctx->stop, 0);
        spin_lock_init(&ctx->mtx);