sched: Assume *balance is valid
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Thu, 24 Dec 2009 13:18:21 +0000 (14:18 +0100)
committerIngo Molnar <mingo@elte.hu>
Thu, 21 Jan 2010 12:40:15 +0000 (13:40 +0100)
Since all load_balance() callers will have !NULL balance parameters we
can now assume so and remove a few checks.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched_fair.c

index de5ab1239e04e20d3287628d035a7bfb84cdbd92..0b482f5b5b3b5ae3c23c8ca484d540573832ff23 100644 (file)
@@ -2465,7 +2465,7 @@ static inline void update_sg_lb_stats(struct sched_domain *sd,
         * to do the newly idle load balance.
         */
        if (idle != CPU_NEWLY_IDLE && local_group &&
-           balance_cpu != this_cpu && balance) {
+           balance_cpu != this_cpu) {
                *balance = 0;
                return;
        }
@@ -2528,7 +2528,7 @@ static inline void update_sd_lb_stats(struct sched_domain *sd, int this_cpu,
                update_sg_lb_stats(sd, group, this_cpu, idle, load_idx, sd_idle,
                                local_group, cpus, balance, &sgs);
 
-               if (local_group && balance && !(*balance))
+               if (local_group && !(*balance))
                        return;
 
                sds->total_load += sgs.group_load;
@@ -2720,7 +2720,7 @@ find_busiest_group(struct sched_domain *sd, int this_cpu,
         * 5) The imbalance is within the specified limit.
         * 6) Any rebalance would lead to ping-pong
         */
-       if (balance && !(*balance))
+       if (!(*balance))
                goto ret;
 
        if (!sds.busiest || sds.busiest_nr_running == 0)