nvme-rdma: unquiesce queues when deleting the controller
authorSagi Grimberg <sagi@grimberg.me>
Mon, 9 Jul 2018 09:49:05 +0000 (12:49 +0300)
committerChristoph Hellwig <hch@lst.de>
Tue, 24 Jul 2018 13:55:49 +0000 (15:55 +0200)
If the controller is going away, we need to unquiesce the IO queues so
that all pending request can fail gracefully before moving forward with
controller deletion. Do that before we destroy the IO queues so
blk_cleanup_queue won't block in freeze.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/rdma.c

index 2d4a51a80e8fb18d41275fababdb7f1a14ef8e3c..2b683b8d47637c3ebb24782a0f7091f3f8f41714 100644 (file)
@@ -1759,6 +1759,8 @@ static void nvme_rdma_shutdown_ctrl(struct nvme_rdma_ctrl *ctrl, bool shutdown)
                nvme_rdma_stop_io_queues(ctrl);
                blk_mq_tagset_busy_iter(&ctrl->tag_set,
                                        nvme_cancel_request, &ctrl->ctrl);
+               if (shutdown)
+                       nvme_start_queues(&ctrl->ctrl);
                nvme_rdma_destroy_io_queues(ctrl, shutdown);
        }