perf intel-pt: Fix timestamp following overflow
authorAdrian Hunter <adrian.hunter@intel.com>
Wed, 7 Mar 2018 14:02:24 +0000 (16:02 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 8 Mar 2018 13:05:56 +0000 (10:05 -0300)
timestamp_insn_cnt is used to estimate the timestamp based on the number of
instructions since the last known timestamp.

If the estimate is not accurate enough decoding might not be correctly
synchronized with side-band events causing more trace errors.

However there are always timestamps following an overflow, so the
estimate is not needed and can indeed result in more errors.

Suppress the estimate by setting timestamp_insn_cnt to zero.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1520431349-30689-5-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/intel-pt-decoder/intel-pt-decoder.c

index 5e4d0bbafc8bde9cdcd9b7117e068db5c03d1f6e..f9157aed12890f3f3dc417dba9c55aeea7ac537e 100644 (file)
@@ -1378,6 +1378,7 @@ static int intel_pt_overflow(struct intel_pt_decoder *decoder)
        intel_pt_clear_tx_flags(decoder);
        decoder->have_tma = false;
        decoder->cbr = 0;
+       decoder->timestamp_insn_cnt = 0;
        decoder->pkt_state = INTEL_PT_STATE_ERR_RESYNC;
        decoder->overflow = true;
        return -EOVERFLOW;