net: hns3: Fix for netdev not up problem when setting mtu

Currently hns3_nic_change_mtu will try to down the netdev before
setting mtu, and it does not up the netdev when the setting fails,
which causes netdev not up problem.

This patch fixes it by not returning when the setting fails.

Fixes: a8e8b7ff3517 ("net: hns3: Add support to change MTU in HNS3 hardware")
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 3fc38228f45969388e8ee1b85979d56965b2779a..545777ae2bc67036eee6d54c5dc463742546f63d 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -1491,13 +1491,11 @@ static int hns3_nic_change_mtu(struct net_device *netdev, int new_mtu)
        }
 
        ret = h->ae_algo->ops->set_mtu(h, new_mtu);
-       if (ret) {
+       if (ret)
                netdev_err(netdev, "failed to change MTU in hardware %d\n",
                           ret);
-               return ret;
-       }
-
-       netdev->mtu = new_mtu;
+       else
+               netdev->mtu = new_mtu;
 
        /* if the netdev was running earlier, bring it up again */
        if (if_running && hns3_nic_net_open(netdev))