cxgb4: Added missing break in ndo_udp_tunnel_{add/del}
authorArjun Vynipadath <arjun@chelsio.com>
Wed, 25 Jul 2018 14:09:52 +0000 (19:39 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Jul 2018 05:38:49 +0000 (22:38 -0700)
Break statements were missing for Geneve case in
ndo_udp_tunnel_{add/del}, thereby raw mac matchall
entries were not getting added.

Fixes: c746fc0e8b2d("cxgb4: add geneve offload support for T6")
Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

index bc03c175a3cdf1440aca2269b4483f59cdb3a9dc..a8926e97935eb01ecdea10cfe760b13d3409634c 100644 (file)
@@ -3072,6 +3072,7 @@ static void cxgb_del_udp_tunnel(struct net_device *netdev,
 
                adapter->geneve_port = 0;
                t4_write_reg(adapter, MPS_RX_GENEVE_TYPE_A, 0);
+               break;
        default:
                return;
        }
@@ -3157,6 +3158,7 @@ static void cxgb_add_udp_tunnel(struct net_device *netdev,
 
                t4_write_reg(adapter, MPS_RX_GENEVE_TYPE_A,
                             GENEVE_V(be16_to_cpu(ti->port)) | GENEVE_EN_F);
+               break;
        default:
                return;
        }