PCI: rockchip: Check for clk_prepare_enable() errors during resume

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>

diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index 86413b884b4ae4abed99191176764c20f961adb6..199edd533083c7dcc00cdad043d51dc11e1f1a30 100644 (file)
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -1308,24 +1308,46 @@ static int __maybe_unused rockchip_pcie_resume_noirq(struct device *dev)
                }
        }
 
-       clk_prepare_enable(rockchip->clk_pcie_pm);
-       clk_prepare_enable(rockchip->hclk_pcie);
-       clk_prepare_enable(rockchip->aclk_perf_pcie);
-       clk_prepare_enable(rockchip->aclk_pcie);
+       err = clk_prepare_enable(rockchip->clk_pcie_pm);
+       if (err)
+               goto err_pcie_pm;
+
+       err = clk_prepare_enable(rockchip->hclk_pcie);
+       if (err)
+               goto err_hclk_pcie;
+
+       err = clk_prepare_enable(rockchip->aclk_perf_pcie);
+       if (err)
+               goto err_aclk_perf_pcie;
+
+       err = clk_prepare_enable(rockchip->aclk_pcie);
+       if (err)
+               goto err_aclk_pcie;
 
        err = rockchip_pcie_init_port(rockchip);
        if (err)
-               return err;
+               goto err_pcie_resume;
 
        err = rockchip_pcie_cfg_atu(rockchip);
        if (err)
-               return err;
+               goto err_pcie_resume;
 
        /* Need this to enter L1 again */
        rockchip_pcie_update_txcredit_mui(rockchip);
        rockchip_pcie_enable_interrupts(rockchip);
 
        return 0;
+
+err_pcie_resume:
+       clk_disable_unprepare(rockchip->aclk_pcie);
+err_aclk_pcie:
+       clk_disable_unprepare(rockchip->aclk_perf_pcie);
+err_aclk_perf_pcie:
+       clk_disable_unprepare(rockchip->hclk_pcie);
+err_hclk_pcie:
+       clk_disable_unprepare(rockchip->clk_pcie_pm);
+err_pcie_pm:
+       return err;
 }
 
 static int rockchip_pcie_probe(struct platform_device *pdev)