perf hists: Introduce hists__scnprint_title()
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 2 Apr 2018 17:20:20 +0000 (14:20 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 3 Apr 2018 13:23:18 +0000 (10:23 -0300)
That is not use any struct hists_browser internals, so that it can be
shared with the other UIs and tools.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Martin Liška <mliska@suse.cz>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196935
Link: https://lkml.kernel.org/n/tip-w8mczjnqnbcj9yzfkv9ja6ro@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/hists.c
tools/perf/util/hist.h

index 2ac66011354fd61d5002d8005cde3d770b5a7baa..c20f0ad22f34e5550d61a75bdeb89cfc75eda25f 100644 (file)
@@ -2208,10 +2208,8 @@ static inline bool is_report_browser(void *timer)
        return timer == NULL;
 }
 
-static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf, size_t size)
+int __hists__scnprintf_title(struct hists *hists, char *bf, size_t size, bool show_freq)
 {
-       struct hist_browser_timer *hbt = browser->hbt;
-       struct hists *hists = browser->hists;
        char unit;
        int printed;
        const struct dso *dso = hists->dso_filter;
@@ -2254,7 +2252,7 @@ static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf
            strstr(ev_name, "call-graph=no"))
                enable_ref = true;
 
-       if (!is_report_browser(hbt))
+       if (show_freq)
                scnprintf(sample_freq_str, sizeof(sample_freq_str), " %d Hz,", evsel->attr.sample_freq);
 
        nr_samples = convert_unit(nr_samples, &unit);
@@ -2285,6 +2283,15 @@ static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf
        if (socket_id > -1)
                printed += scnprintf(bf + printed, size - printed,
                                    ", Processor Socket: %d", socket_id);
+
+       return printed;
+}
+
+static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf, size_t size)
+{
+       struct hist_browser_timer *hbt = browser->hbt;
+       int printed = __hists__scnprintf_title(browser->hists, bf, size, !is_report_browser(hbt));
+
        if (!is_report_browser(hbt)) {
                struct perf_top *top = hbt->arg;
 
index 32fbf26e0c18b67dda8ce541e18ab0bd2c9f198e..fbabfd8a215df5cb02ade975d4f58e4ebaeb42b2 100644 (file)
@@ -504,5 +504,11 @@ int __hpp__slsmg_color_printf(struct perf_hpp *hpp, const char *fmt, ...);
 int __hist_entry__snprintf(struct hist_entry *he, struct perf_hpp *hpp,
                           struct perf_hpp_list *hpp_list);
 int hists__fprintf_headers(struct hists *hists, FILE *fp);
+int __hists__scnprintf_title(struct hists *hists, char *bf, size_t size, bool show_freq);
+
+static inline int hists__scnprintf_title(struct hists *hists, char *bf, size_t size)
+{
+       return __hists__scnprintf_title(hists, bf, size, true);
+}
 
 #endif /* __PERF_HIST_H */