ath10k: ath10k_snoc_{read,write}32() should be static
authorBrian Norris <briannorris@chromium.org>
Fri, 2 Nov 2018 18:10:00 +0000 (11:10 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 6 Nov 2018 16:18:24 +0000 (18:18 +0200)
They're provided as callbacks in ath10k_hif_ops and should be accessed
that way, if needed outside of snoc.c, and anyway, they're currently
unused outside snoc.c.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/snoc.c
drivers/net/wireless/ath/ath10k/snoc.h

index 81b86a787c34c82d0a93a0fac88ba8042743cb88..85116986161c9f43ff07b3ca22ab5ec3411127eb 100644 (file)
@@ -474,14 +474,14 @@ static struct service_to_pipe target_service_to_ce_map_wlan[] = {
        },
 };
 
-void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value)
+static void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value)
 {
        struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
 
        iowrite32(value, ar_snoc->mem + offset);
 }
 
-u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset)
+static u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset)
 {
        struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
        u32 val;
index d0fcf99a8ecade5302bcac5b8438944ac3347c41..2b2f23cf7c5dccfd419bd8c2a943246cb46b9cc6 100644 (file)
@@ -98,8 +98,6 @@ static inline struct ath10k_snoc *ath10k_snoc_priv(struct ath10k *ar)
        return (struct ath10k_snoc *)ar->drv_priv;
 }
 
-void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value);
-u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset);
 int ath10k_snoc_fw_indication(struct ath10k *ar, u64 type);
 
 #endif /* _SNOC_H_ */