drm/amd/display: Drop DCN1_01 guards
authorHarry Wentland <harry.wentland@amd.com>
Tue, 14 May 2019 13:12:45 +0000 (09:12 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 24 May 2019 17:20:59 +0000 (12:20 -0500)
[WHY]
These were only needed for bringup. They're not needed anymore.

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/Kconfig
drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c
drivers/gpu/drm/amd/display/dc/core/dc_resource.c
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
drivers/gpu/drm/amd/display/dc/gpio/hw_factory.c
drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
drivers/gpu/drm/amd/display/include/dal_asic_id.h
drivers/gpu/drm/amd/display/include/dal_types.h

index 13a6ce9c8e94a30478058db0d0d7dbd3a9bb8c33..ed654a76c76ab3bf074ec07c2a33aa2f2e3cca3d 100644 (file)
@@ -5,7 +5,6 @@ config DRM_AMD_DC
        bool "AMD DC - Enable new display engine"
        default y
        select DRM_AMD_DC_DCN1_0 if X86 && !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS)
-       select DRM_AMD_DC_DCN1_01 if X86 && !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS)
        help
          Choose this option if you want to use the new display engine
          support for AMDGPU. This adds required support for Vega and
@@ -16,11 +15,6 @@ config DRM_AMD_DC_DCN1_0
        help
          RV family support for display engine
 
-config DRM_AMD_DC_DCN1_01
-       def_bool n
-       help
-         RV2 family for display engine
-
 config DEBUG_KERNEL_DC
        bool "Enable kgdb break in DC"
        depends on DRM_AMD_DC
index 8196f3bb10c786c983a57e14bdfe92fac32c519f..53deba42007af39e5eb455e615ccc75678365200 100644 (file)
@@ -57,11 +57,6 @@ bool dal_bios_parser_init_cmd_tbl_helper2(
                return true;
 #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
        case DCN_VERSION_1_0:
-               *h = dal_cmd_tbl_helper_dce112_get_table2();
-               return true;
-#endif
-
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        case DCN_VERSION_1_01:
                *h = dal_cmd_tbl_helper_dce112_get_table2();
                return true;
index 58ce7a6b914ca0a71f4fdf1e192de46cdf6bcf59..d9bfffb2c48dbbac260c9e91185392bf89ec374d 100644 (file)
@@ -93,10 +93,8 @@ enum dce_version resource_parse_asic_id(struct hw_asic_id asic_id)
 #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
        case FAMILY_RV:
                dc_version = DCN_VERSION_1_0;
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
                if (ASICREV_IS_RAVEN2(asic_id.hw_internal_rev))
                        dc_version = DCN_VERSION_1_01;
-#endif
                break;
 #endif
        default:
@@ -147,9 +145,7 @@ struct resource_pool *dc_create_resource_pool(struct dc  *dc,
 
 #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
        case DCN_VERSION_1_0:
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        case DCN_VERSION_1_01:
-#endif
                res_pool = dcn10_create_resource_pool(init_data, dc);
                break;
 #endif
index 1772475959741dee49453b0d6b2329ab210fca1f..bf978831bb0ea8af98598611ab2d8fbd99f08b1a 100644 (file)
@@ -927,9 +927,7 @@ void hubbub1_construct(struct hubbub *hubbub,
        hubbub1->masks = hubbub_mask;
 
        hubbub1->debug_test_index_pstate = 0x7;
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        if (ctx->dce_version == DCN_VERSION_1_01)
                hubbub1->debug_test_index_pstate = 0xB;
-#endif
 }
 
index ddb020a5309837005ed2b7c578175e9d19568184..dc7cf37042523f641f06542dceb44c212713e49c 100644 (file)
@@ -152,9 +152,7 @@ enum dcn10_clk_src_array_id {
        DCN10_CLK_SRC_PLL2,
        DCN10_CLK_SRC_PLL3,
        DCN10_CLK_SRC_TOTAL,
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        DCN101_CLK_SRC_TOTAL = DCN10_CLK_SRC_PLL3
-#endif
 };
 
 /* begin *********************
@@ -522,7 +520,6 @@ static const struct resource_caps res_cap = {
                .num_ddc = 4,
 };
 
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
 static const struct resource_caps rv2_res_cap = {
                .num_timing_generator = 3,
                .num_opp = 3,
@@ -532,7 +529,6 @@ static const struct resource_caps rv2_res_cap = {
                .num_pll = 3,
                .num_ddc = 3,
 };
-#endif
 
 static const struct dc_plane_cap plane_cap = {
        .type = DC_PLANE_TYPE_DCN_UNIVERSAL,
@@ -1270,11 +1266,9 @@ static bool construct(
 
        ctx->dc_bios->regs = &bios_regs;
 
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        if (ctx->dce_version == DCN_VERSION_1_01)
                pool->base.res_cap = &rv2_res_cap;
        else
-#endif
                pool->base.res_cap = &res_cap;
        pool->base.funcs = &dcn10_res_pool_funcs;
 
@@ -1291,10 +1285,8 @@ static bool construct(
        /* max pipe num for ASIC before check pipe fuses */
        pool->base.pipe_count = pool->base.res_cap->num_timing_generator;
 
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        if (dc->ctx->dce_version == DCN_VERSION_1_01)
                pool->base.pipe_count = 3;
-#endif
        dc->caps.max_video_width = 3840;
        dc->caps.max_downscale_ratio = 200;
        dc->caps.i2c_speed_in_khz = 100;
@@ -1327,26 +1319,17 @@ static bool construct(
                                CLOCK_SOURCE_COMBO_PHY_PLL2,
                                &clk_src_regs[2], false);
 
-#ifdef CONFIG_DRM_AMD_DC_DCN1_01
        if (dc->ctx->dce_version == DCN_VERSION_1_0) {
                pool->base.clock_sources[DCN10_CLK_SRC_PLL3] =
                                dcn10_clock_source_create(ctx, ctx->dc_bios,
                                        CLOCK_SOURCE_COMBO_PHY_PLL3,
                                        &clk_src_regs[3], false);
        }
-#else
-       pool->base.clock_sources[DCN10_CLK_SRC_PLL3] =
-                       dcn10_clock_source_create(ctx, ctx->dc_bios,
-                               CLOCK_SOURCE_COMBO_PHY_PLL3,
-                               &clk_src_regs[3], false);
-#endif
 
        pool->base.clk_src_count = DCN10_CLK_SRC_TOTAL;
 
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        if (dc->ctx->dce_version == DCN_VERSION_1_01)
                pool->base.clk_src_count = DCN101_CLK_SRC_TOTAL;
-#endif
 
        pool->base.dp_clock_source =
                        dcn10_clock_source_create(ctx, ctx->dc_bios,
@@ -1386,7 +1369,6 @@ static bool construct(
        memcpy(dc->dcn_ip, &dcn10_ip_defaults, sizeof(dcn10_ip_defaults));
        memcpy(dc->dcn_soc, &dcn10_soc_defaults, sizeof(dcn10_soc_defaults));
 
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        if (dc->ctx->dce_version == DCN_VERSION_1_01) {
                struct dcn_soc_bounding_box *dcn_soc = dc->dcn_soc;
                struct dcn_ip_params *dcn_ip = dc->dcn_ip;
@@ -1397,7 +1379,6 @@ static bool construct(
                dcn_soc->dram_clock_change_latency = 23;
                dcn_ip->max_num_dpp = 3;
        }
-#endif
        if (ASICREV_IS_RV1_F0(dc->ctx->asic_id.hw_internal_rev)) {
                dc->dcn_soc->urgent_latency = 3;
                dc->debug.disable_dmcu = true;
index c2028c4744a6446ff9bb0b3d5b838262f8d6e35e..a610fae162807d2c56efb9e0e7ca1f71ca7cdbce 100644 (file)
@@ -84,10 +84,6 @@ bool dal_hw_factory_init(
                return true;
 #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
        case DCN_VERSION_1_0:
-               dal_hw_factory_dcn10_init(factory);
-               return true;
-#endif
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        case DCN_VERSION_1_01:
                dal_hw_factory_dcn10_init(factory);
                return true;
index 236ca28784a9cf505fe2c046e8b0ded3dbcbf486..77615146b96e2879c5e12dcdd0b468519da2641a 100644 (file)
@@ -84,11 +84,6 @@ bool dal_hw_translate_init(
                dal_hw_translate_dcn10_init(translate);
                return true;
 #endif
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
-       case DCN_VERSION_1_01:
-               dal_hw_translate_dcn10_init(translate);
-               return true;
-#endif
 
        default:
                BREAK_TO_DEBUGGER();
index 072d8d7debf53ab1e1e939f730f3666dd507fddf..63c3e77159d916e96ee11c23007c4cf2aa0c3e4b 100644 (file)
 #define INTERNAL_REV_RAVEN_A0             0x00    /* First spin of Raven */
 #define RAVEN_A0 0x01
 #define RAVEN_B0 0x21
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
 /* DCN1_01 */
 #define PICASSO_A0 0x41
 #define RAVEN2_A0 0x81
-#endif
 #define RAVEN1_F0 0xF0
 #define RAVEN_UNKNOWN 0xFF
 
 #define RAVEN1_F0 0xF0
 #define ASICREV_IS_RV1_F0(eChipRev) ((eChipRev >= RAVEN1_F0) && (eChipRev < RAVEN_UNKNOWN))
 
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
 #define ASICREV_IS_PICASSO(eChipRev) ((eChipRev >= PICASSO_A0) && (eChipRev < RAVEN2_A0))
 #define ASICREV_IS_RAVEN2(eChipRev) ((eChipRev >= RAVEN2_A0) && (eChipRev < 0xF0))
-#endif /* DCN1_01 */
 
 #define FAMILY_RV 142 /* DCN 1*/
 
index f5bd869d4320bdd6f552d1344e025372d15d4e21..dabdbc0999d4459332210316c51f0693e127238d 100644 (file)
@@ -45,9 +45,7 @@ enum dce_version {
        DCE_VERSION_12_1,
        DCE_VERSION_MAX,
        DCN_VERSION_1_0,
-#if defined(CONFIG_DRM_AMD_DC_DCN1_01)
        DCN_VERSION_1_01,
-#endif /* DCN1_01 */
        DCN_VERSION_MAX
 };