staging: mt7621-eth: fix return value check in mtk_connect_phy_node()

In case of error, the function of_phy_connect() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: e3cbf478f846 ("staging: mt7621-eth: add the drivers core files")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/mt7621-eth/mdio.c b/drivers/staging/mt7621-eth/mdio.c
index 96ecda930c4803860ca8c8cbdedecd63a7a1375a..9d713078ef901b4ed18c3b73fea2e8b679925386 100644 (file)
--- a/drivers/staging/mt7621-eth/mdio.c
+++ b/drivers/staging/mt7621-eth/mdio.c
@@ -82,10 +82,10 @@ int mtk_connect_phy_node(struct mtk_eth *eth, struct mtk_mac *mac,
 
        phydev = of_phy_connect(eth->netdev[mac->id], phy_node,
                                mtk_phy_link_adjust, 0, phy_mode);
-       if (IS_ERR(phydev)) {
+       if (!phydev) {
                dev_err(eth->dev, "could not connect to PHY\n");
                eth->phy->phy_node[port] = NULL;
-               return PTR_ERR(phydev);
+               return -ENODEV;
        }
 
        phydev->supported &= PHY_GBIT_FEATURES;