pwm: Drop legacy wrapper for changing polarity
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 15 Oct 2018 08:21:52 +0000 (10:21 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 12 Dec 2018 10:55:42 +0000 (11:55 +0100)
The API to configure a PWM using pwm_enable(), pwm_disable(),
pwm_config() and pwm_set_polarity() is superseeded by atomically setting
the parameters using pwm_apply_state(). To get forward with deprecating
the former set of functions use the opportunity that there is no current
user of pwm_set_polarity() and remove it.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
include/linux/pwm.h

index 56518adc31dd702bc849078005a564b8ae6fa0df..d5199b507d79527a6f5278194596b0c42f452e9c 100644 (file)
@@ -348,42 +348,6 @@ static inline int pwm_config(struct pwm_device *pwm, int duty_ns,
        return pwm_apply_state(pwm, &state);
 }
 
-/**
- * pwm_set_polarity() - configure the polarity of a PWM signal
- * @pwm: PWM device
- * @polarity: new polarity of the PWM signal
- *
- * Note that the polarity cannot be configured while the PWM device is
- * enabled.
- *
- * Returns: 0 on success or a negative error code on failure.
- */
-static inline int pwm_set_polarity(struct pwm_device *pwm,
-                                  enum pwm_polarity polarity)
-{
-       struct pwm_state state;
-
-       if (!pwm)
-               return -EINVAL;
-
-       pwm_get_state(pwm, &state);
-       if (state.polarity == polarity)
-               return 0;
-
-       /*
-        * Changing the polarity of a running PWM without adjusting the
-        * dutycycle/period value is a bit risky (can introduce glitches).
-        * Return -EBUSY in this case.
-        * Note that this is allowed when using pwm_apply_state() because
-        * the user specifies all the parameters.
-        */
-       if (state.enabled)
-               return -EBUSY;
-
-       state.polarity = polarity;
-       return pwm_apply_state(pwm, &state);
-}
-
 /**
  * pwm_enable() - start a PWM output toggling
  * @pwm: PWM device
@@ -483,12 +447,6 @@ static inline int pwm_capture(struct pwm_device *pwm,
        return -EINVAL;
 }
 
-static inline int pwm_set_polarity(struct pwm_device *pwm,
-                                  enum pwm_polarity polarity)
-{
-       return -ENOTSUPP;
-}
-
 static inline int pwm_enable(struct pwm_device *pwm)
 {
        return -EINVAL;