trace_uprobe: Simplify probes_seq_show()
authorRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Thu, 15 Mar 2018 08:27:56 +0000 (13:57 +0530)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 11 Apr 2018 15:31:07 +0000 (11:31 -0400)
Simplify probes_seq_show() function. No change in output
before and after patch.

Link: http://lkml.kernel.org/r/20180315082756.9050-2-ravi.bangoria@linux.vnet.ibm.com
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_uprobe.c

index d7d3c9237f6429cf08a8cd10c35bd02cb471d9a0..21604754bb79eafa293845fe2475175f5bb57351 100644 (file)
@@ -602,24 +602,9 @@ static int probes_seq_show(struct seq_file *m, void *v)
        char c = is_ret_probe(tu) ? 'r' : 'p';
        int i;
 
-       seq_printf(m, "%c:%s/%s", c, tu->tp.call.class->system,
-                       trace_event_name(&tu->tp.call));
-       seq_printf(m, " %s:", tu->filename);
-
-       /* Don't print "0x  (null)" when offset is 0 */
-       if (tu->offset) {
-               seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset);
-       } else {
-               switch (sizeof(void *)) {
-               case 4:
-                       seq_printf(m, "0x00000000");
-                       break;
-               case 8:
-               default:
-                       seq_printf(m, "0x0000000000000000");
-                       break;
-               }
-       }
+       seq_printf(m, "%c:%s/%s %s:0x%0*lx", c, tu->tp.call.class->system,
+                       trace_event_name(&tu->tp.call), tu->filename,
+                       (int)(sizeof(void *) * 2), tu->offset);
 
        for (i = 0; i < tu->tp.nr_args; i++)
                seq_printf(m, " %s=%s", tu->tp.args[i].name, tu->tp.args[i].comm);