usb: ohci-platform: Use devm_of_phy_get_by_index

Getting phys by index instead of phy names so that we do
not have to create a naming scheme when multiple phys are present

Signed-off-by: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 185ceee52d47e5129e35815f899fa50e4416de25..c2669f185f658c76f74e9f5c8ec651cbb92ec397 100644 (file)
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -57,15 +57,13 @@ static int ohci_platform_power_on(struct platform_device *dev)
        }
 
        for (phy_num = 0; phy_num < priv->num_phys; phy_num++) {
-               if (priv->phys[phy_num]) {
-                       ret = phy_init(priv->phys[phy_num]);
-                       if (ret)
-                               goto err_exit_phy;
-                       ret = phy_power_on(priv->phys[phy_num]);
-                       if (ret) {
-                               phy_exit(priv->phys[phy_num]);
-                               goto err_exit_phy;
-                       }
+               ret = phy_init(priv->phys[phy_num]);
+               if (ret)
+                       goto err_exit_phy;
+               ret = phy_power_on(priv->phys[phy_num]);
+               if (ret) {
+                       phy_exit(priv->phys[phy_num]);
+                       goto err_exit_phy;
                }
        }
 
@@ -73,10 +71,8 @@ static int ohci_platform_power_on(struct platform_device *dev)
 
 err_exit_phy:
        while (--phy_num >= 0) {
-               if (priv->phys[phy_num]) {
-                       phy_power_off(priv->phys[phy_num]);
-                       phy_exit(priv->phys[phy_num]);
-               }
+               phy_power_off(priv->phys[phy_num]);
+               phy_exit(priv->phys[phy_num]);
        }
 err_disable_clks:
        while (--clk >= 0)
@@ -92,10 +88,8 @@ static void ohci_platform_power_off(struct platform_device *dev)
        int clk, phy_num;
 
        for (phy_num = 0; phy_num < priv->num_phys; phy_num++) {
-               if (priv->phys[phy_num]) {
-                       phy_power_off(priv->phys[phy_num]);
-                       phy_exit(priv->phys[phy_num]);
-               }
+               phy_power_off(priv->phys[phy_num]);
+               phy_exit(priv->phys[phy_num]);
        }
 
        for (clk = OHCI_MAX_CLKS - 1; clk >= 0; clk--)
@@ -123,7 +117,6 @@ static int ohci_platform_probe(struct platform_device *dev)
        struct usb_ohci_pdata *pdata = dev_get_platdata(&dev->dev);
        struct ohci_platform_priv *priv;
        struct ohci_hcd *ohci;
-       const char *phy_name;
        int err, irq, phy_num, clk = 0;
 
        if (usb_disabled())
@@ -174,36 +167,22 @@ static int ohci_platform_probe(struct platform_device *dev)
 
                priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
                                "phys", "#phy-cells");
-               priv->num_phys = priv->num_phys > 0 ? priv->num_phys : 1;
 
-               priv->phys = devm_kcalloc(&dev->dev, priv->num_phys,
-                               sizeof(struct phy *), GFP_KERNEL);
-               if (!priv->phys)
-                       return -ENOMEM;
+               if (priv->num_phys > 0) {
+                       priv->phys = devm_kcalloc(&dev->dev, priv->num_phys,
+                                           sizeof(struct phy *), GFP_KERNEL);
+                       if (!priv->phys)
+                               return -ENOMEM;
+               } else
+                       priv->num_phys = 0;
 
                for (phy_num = 0; phy_num < priv->num_phys; phy_num++) {
-                               err = of_property_read_string_index(
-                                               dev->dev.of_node,
-                                               "phy-names", phy_num,
-                                               &phy_name);
-
-                               if (err < 0) {
-                                       if (priv->num_phys > 1) {
-                                               dev_err(&dev->dev, "phy-names not provided");
-                                               goto err_put_hcd;
-                                       } else
-                                               phy_name = "usb";
-                               }
-
-                               priv->phys[phy_num] = devm_phy_get(&dev->dev,
-                                               phy_name);
-                               if (IS_ERR(priv->phys[phy_num])) {
-                                       err = PTR_ERR(priv->phys[phy_num]);
-                                       if ((priv->num_phys > 1) ||
-                                           (err == -EPROBE_DEFER))
-                                               goto err_put_hcd;
-                                       priv->phys[phy_num] = NULL;
-                               }
+                       priv->phys[phy_num] = devm_of_phy_get_by_index(
+                                       &dev->dev, dev->dev.of_node, phy_num);
+                       if (IS_ERR(priv->phys[phy_num])) {
+                               err = PTR_ERR(priv->phys[phy_num]);
+                               goto err_put_hcd;
+                       }
                }
 
                for (clk = 0; clk < OHCI_MAX_CLKS; clk++) {