ip6_gre: fix error path when ip6erspan_rcv failed
authorHaishuang Yan <yanhaishuang@cmss.chinamobile.com>
Wed, 20 Dec 2017 02:21:47 +0000 (10:21 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 20 Dec 2017 18:51:46 +0000 (13:51 -0500)
Same as ipv4 code, when ip6erspan_rcv call return PACKET_REJECT, we
should call icmpv6_send to send icmp unreachable message in error path.

Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support")
Acked-by: William Tu <u9012063@gmail.com>
Cc: William Tu <u9012063@gmail.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6_gre.c

index 9bd110371fe374f92b35199053bb62db7ebbc1aa..b7a79ddcf8516bc725220f073127e9b9f58acfbc 100644 (file)
@@ -602,12 +602,13 @@ static int gre_rcv(struct sk_buff *skb)
                     tpi.proto == htons(ETH_P_ERSPAN2))) {
                if (ip6erspan_rcv(skb, hdr_len, &tpi) == PACKET_RCVD)
                        return 0;
-               goto drop;
+               goto out;
        }
 
        if (ip6gre_rcv(skb, &tpi) == PACKET_RCVD)
                return 0;
 
+out:
        icmpv6_send(skb, ICMPV6_DEST_UNREACH, ICMPV6_PORT_UNREACH, 0);
 drop:
        kfree_skb(skb);