ksmbd: select ASN1 explicitly to reduce dependencies

ksmbd requires ASN.1 grammar compiler so it depends on CONFIG_ASN1. It
should select kmod-asn1-decoder for above reason.

Due to some problems with kmod-asn1-decoder in the past ksmbd was
selecting kmod-nf-nathelper-extra instead. That was affecting network
performance in kernel as each loaded conntrack module adds some overhead
to packets processing.

Fix this unwanted side effect by depending on kmod-asn1-decoder
directly.

Link: http://lists.openwrt.org/pipermail/openwrt-devel/2023-January/040298.html
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

diff --git a/kernel/ksmbd/Makefile b/kernel/ksmbd/Makefile
index 11f183d9e027fbcb8ec75b15f5bbf9a8b6d68bac..e7f55c9b63f9375c1576e7ba56cf561ce844cda8 100644 (file)
--- a/kernel/ksmbd/Makefile
+++ b/kernel/ksmbd/Makefile
@@ -24,6 +24,7 @@ define KernelPackage/fs-ksmbd
        URL:=https://github.com/cifsd-team/cifsd
        FILES:=$(PKG_BUILD_DIR)/ksmbd.ko
        DEPENDS:= \
+               +kmod-asn1-decoder \
                +kmod-nls-base \
                +kmod-nls-utf8 \
                +kmod-crypto-md4 \
@@ -37,11 +38,10 @@ define KernelPackage/fs-ksmbd
                +kmod-crypto-aead \
                +kmod-crypto-ccm \
                +kmod-crypto-gcm \
-               +kmod-fs-nfsd \
-               +kmod-nf-nathelper-extra
+               +kmod-fs-nfsd
 endef
 
-# The last two DEPENDS are hacks in order to get CONFIG_ASN1 and CONFIG_OID_REGISTRY
+# The last DEPENDS entry is a hack in order to get CONFIG_OID_REGISTRY
 # which it seems can't be selected independently. Some bug in either base or upstream.
 
 define KernelPackage/fs-ksmbd/description