media: go7007: fix two sparse warnings

drivers/media/usb/go7007/go7007-v4l2.c:637:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
drivers/media/usb/go7007/go7007-fw.c:1507:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/usb/go7007/go7007-fw.c b/drivers/media/usb/go7007/go7007-fw.c
index 60bf5f0644d116f9d73e06b320740c0acaf5f786..87b4fc48ef09ada7881dd39b1047fc52231f6ec0 100644 (file)
--- a/drivers/media/usb/go7007/go7007-fw.c
+++ b/drivers/media/usb/go7007/go7007-fw.c
@@ -1514,7 +1514,10 @@ static int do_special(struct go7007 *go, u16 type, __le16 *code, int space,
                case V4L2_PIX_FMT_MPEG4:
                        return gen_mpeg4hdr_to_package(go, code, space,
                                                                framelen);
+               default:
+                       break;
                }
+               break;
        case SPECIAL_BRC_CTRL:
                return brctrl_to_package(go, code, space, framelen);
        case SPECIAL_CONFIG:

diff --git a/drivers/media/usb/go7007/go7007-v4l2.c b/drivers/media/usb/go7007/go7007-v4l2.c
index 98cd57eaf36a4d1923a993f7a6b75728cfa0f25e..c55c82f70e541b2b6483ae2c840a3f08f35d5f22 100644 (file)
--- a/drivers/media/usb/go7007/go7007-v4l2.c
+++ b/drivers/media/usb/go7007/go7007-v4l2.c
@@ -634,7 +634,7 @@ static int vidioc_enum_input(struct file *file, void *priv,
        if (inp->index >= go->board_info->num_inputs)
                return -EINVAL;
 
-       strncpy(inp->name, go->board_info->inputs[inp->index].name,
+       strlcpy(inp->name, go->board_info->inputs[inp->index].name,
                        sizeof(inp->name));
 
        /* If this board has a tuner, it will be the first input */