arm64: kprobes: Move extable address check into arch_prepare_kprobe()
authorMasami Hiramatsu <mhiramat@kernel.org>
Tue, 12 Feb 2019 15:43:22 +0000 (00:43 +0900)
committerCatalin Marinas <catalin.marinas@arm.com>
Tue, 19 Mar 2019 12:42:58 +0000 (12:42 +0000)
Move extable address check into arch_prepare_kprobe() from
arch_within_kprobe_blacklist().
The blacklist is exposed via debugfs as a list of symbols.
The extable entries are smaller, so must be filtered out
by arch_prepare_kprobe().

Acked-by: Will Deacon <will.deacon@arm.com>
Reviewed-by: James Morse <james.morse@arm.com>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/probes/kprobes.c

index 7fb6f3aa5ceb7172c91277067da624085b158433..16bc3b2e93515562da555d786c2e7d9157211776 100644 (file)
@@ -102,6 +102,10 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p)
 
        if (in_exception_text(probe_addr))
                return -EINVAL;
+
+       if (search_exception_tables(probe_addr))
+               return -EINVAL;
+
        if (probe_addr >= (unsigned long) __start_rodata &&
            probe_addr <= (unsigned long) __end_rodata)
                return -EINVAL;
@@ -485,8 +489,7 @@ bool arch_within_kprobe_blacklist(unsigned long addr)
            (addr >= (unsigned long)__idmap_text_start &&
            addr < (unsigned long)__idmap_text_end) ||
            (addr >= (unsigned long)__hyp_text_start &&
-           addr < (unsigned long)__hyp_text_end) ||
-           !!search_exception_tables(addr))
+           addr < (unsigned long)__hyp_text_end))
                return true;
 
        if (!is_kernel_in_hyp_mode()) {