vfs: Undo an overly zealous MS_RDONLY -> SB_RDONLY conversion
authorDavid Howells <dhowells@redhat.com>
Fri, 20 Apr 2018 12:35:02 +0000 (13:35 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 20 Apr 2018 16:59:33 +0000 (09:59 -0700)
In do_mount() when the MS_* flags are being converted to MNT_* flags,
MS_RDONLY got accidentally convered to SB_RDONLY.

Undo this change.

Fixes: e462ec50cb5f ("VFS: Differentiate mount flags (MS_*) from internal superblock flags")
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/namespace.c

index 8634d565b85879c61a40ab4995547ca76bebfe4e..5f75969adff18ef9e2390648d93e7dec214913c3 100644 (file)
@@ -2815,7 +2815,7 @@ long do_mount(const char *dev_name, const char __user *dir_name,
                mnt_flags |= MNT_NODIRATIME;
        if (flags & MS_STRICTATIME)
                mnt_flags &= ~(MNT_RELATIME | MNT_NOATIME);
-       if (flags & SB_RDONLY)
+       if (flags & MS_RDONLY)
                mnt_flags |= MNT_READONLY;
 
        /* The default atime for remount is preservation */