brcm80211: smac: precendence bug in wlc_phy_attach()

Negate has higher precendence than compare and since neither zero nor
one are equal to four or eight the original condition is always false.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
index 5b57caa7c3afc9dd057cc0e8a8c2df83ff336009..264f8c4c703daf43251c7bd5185df79fd344e8c2 100644 (file)
--- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
@@ -482,8 +482,8 @@ wlc_phy_attach(struct shared_phy *sh, struct bcma_device *d11core,
        pi->pubpi.phy_corenum = PHY_CORE_NUM_2;
        pi->pubpi.ana_rev = (phyversion & PV_AV_MASK) >> PV_AV_SHIFT;
 
-       if (!pi->pubpi.phy_type == PHY_TYPE_N &&
-           !pi->pubpi.phy_type == PHY_TYPE_LCN)
+       if (pi->pubpi.phy_type != PHY_TYPE_N &&
+           pi->pubpi.phy_type != PHY_TYPE_LCN)
                goto err;
 
        if (bandtype == BRCM_BAND_5G) {