blk-mq: ensure mq_ops ->poll() is entered at least once
authorJens Axboe <axboe@kernel.dk>
Wed, 14 Nov 2018 04:32:10 +0000 (21:32 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Nov 2018 15:25:57 +0000 (08:25 -0700)
Right now we immediately bail if need_resched() is true, but
we need to do at least one loop in case we have entries waiting.
So just invert the need_resched() check, putting it at the
bottom of the loop.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c

index c2751f0a3ccc0f777fff08e473a52ac0f93348f6..ba3c7b6476b77a2ed5da1666bfe15c706712038d 100644 (file)
@@ -3375,7 +3375,7 @@ static int blk_mq_poll(struct request_queue *q, blk_qc_t cookie, bool spin)
        hctx->poll_considered++;
 
        state = current->state;
-       while (!need_resched()) {
+       do {
                int ret;
 
                hctx->poll_invoked++;
@@ -3395,7 +3395,7 @@ static int blk_mq_poll(struct request_queue *q, blk_qc_t cookie, bool spin)
                if (ret < 0 || !spin)
                        break;
                cpu_relax();
-       }
+       } while (!need_resched());
 
        __set_current_state(TASK_RUNNING);
        return 0;