arm64: tishift: use asm EXPORT_SYMBOL()
authorMark Rutland <mark.rutland@arm.com>
Fri, 7 Dec 2018 18:08:17 +0000 (18:08 +0000)
committerWill Deacon <will.deacon@arm.com>
Mon, 10 Dec 2018 11:50:11 +0000 (11:50 +0000)
For a while now it's been possible to use EXPORT_SYMBOL() in assembly
files, which allows us to place exports immediately after assembly
functions, as we do for C functions.

As a step towards removing arm64ksyms.c, let's move the tishift exports
to the assembly file the functions are defined in.

There should be no functional change as a result of this patch.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/arm64ksyms.c
arch/arm64/lib/tishift.S

index 73237dc8a994f5ce20ebaa7ca50d8697a365471a..d80e9cfc306202e81102830b0ee0bf10e8a8647c 100644 (file)
@@ -68,10 +68,3 @@ NOKPROBE_SYMBOL(_mcount);
 EXPORT_SYMBOL(__arm_smccc_smc);
 EXPORT_SYMBOL(__arm_smccc_hvc);
 
-       /* tishift.S */
-extern long long __ashlti3(long long a, int b);
-EXPORT_SYMBOL(__ashlti3);
-extern long long __ashrti3(long long a, int b);
-EXPORT_SYMBOL(__ashrti3);
-extern long long __lshrti3(long long a, int b);
-EXPORT_SYMBOL(__lshrti3);
index 0fdff97794debbdfaae4a146a99b4550e670ab5e..047622536535d4d5698cc3e5cd6b16ad91ec749d 100644 (file)
@@ -5,6 +5,8 @@
 
 #include <linux/linkage.h>
 
+#include <asm/assembler.h>
+
 ENTRY(__ashlti3)
        cbz     x2, 1f
        mov     x3, #64
@@ -25,6 +27,7 @@ ENTRY(__ashlti3)
        mov     x0, x2
        ret
 ENDPROC(__ashlti3)
+EXPORT_SYMBOL(__ashlti3)
 
 ENTRY(__ashrti3)
        cbz     x2, 1f
@@ -46,6 +49,7 @@ ENTRY(__ashrti3)
        mov     x1, x2
        ret
 ENDPROC(__ashrti3)
+EXPORT_SYMBOL(__ashrti3)
 
 ENTRY(__lshrti3)
        cbz     x2, 1f
@@ -67,3 +71,4 @@ ENTRY(__lshrti3)
        mov     x1, x2
        ret
 ENDPROC(__lshrti3)
+EXPORT_SYMBOL(__lshrti3)