Platform: OLPC: Fix build error without CONFIG_SPI
authorYueHaibing <yuehaibing@huawei.com>
Tue, 28 May 2019 09:28:05 +0000 (17:28 +0800)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 11 Jun 2019 18:17:50 +0000 (21:17 +0300)
Fix gcc build error while CONFIG_SPI is not set

drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_remove':
olpc-xo175-ec.c:(.text+0x190): undefined reference to `spi_slave_abort'
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_send_command':
olpc-xo175-ec.c:(.text+0x374): undefined reference to `spi_async'
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_cmd':
olpc-xo175-ec.c:(.text+0x8a0): undefined reference to `spi_slave_abort'
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_spi_driver_init':
olpc-xo175-ec.c:(.init.text+0x14): undefined reference to `__spi_register_driver'

We should depends on CONFIG_SPI_SLAVE other than directly select it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 0c3d931b3ab9 ("Platform: OLPC: Add XO-1.75 EC driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/olpc/Kconfig

index 858ac1d2290a3d115e040eb0551e6a8043a9b4b8..1d3244a25ffc4a613ab12a3e30f87d1a408454d1 100644 (file)
@@ -5,7 +5,7 @@ config OLPC_EC
 config OLPC_XO175_EC
        tristate "OLPC XO 1.75 Embedded Controller"
        depends on ARCH_MMP || COMPILE_TEST
-       select SPI_SLAVE
+       depends on SPI_SLAVE
        select OLPC_EC
        help
          Include support for the OLPC XO Embedded Controller (EC). The EC