drm/amdgpu: drop the huge page flag
authorChristian König <christian.koenig@amd.com>
Fri, 1 Feb 2019 16:11:29 +0000 (17:11 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 19 Mar 2019 20:36:48 +0000 (15:36 -0500)
Not needed any more since we now free PDs/PTs on demand.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Acked-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h

index 92334efa19a8ff3d5ba0cdc6b9a8880e33588584..045da0e5691c30bdad6762e9ee31308405d916d5 100644 (file)
@@ -1371,10 +1371,6 @@ static void amdgpu_vm_update_pde(struct amdgpu_pte_update_params *params,
        uint64_t pde, pt, flags;
        unsigned level;
 
-       /* Don't update huge pages here */
-       if (entry->huge)
-               return;
-
        for (level = 0, pbo = bo->parent; pbo; ++level)
                pbo = pbo->parent;
 
@@ -1638,13 +1634,6 @@ static int amdgpu_vm_update_ptes(struct amdgpu_pte_update_params *params,
                        continue;
                }
 
-               /* If it isn't already handled it can't be a huge page */
-               if (cursor.entry->huge) {
-                       /* Add the entry to the relocated list to update it. */
-                       cursor.entry->huge = false;
-                       amdgpu_vm_bo_relocated(&cursor.entry->base);
-               }
-
                shift = amdgpu_vm_level_shift(adev, cursor.level);
                parent_shift = amdgpu_vm_level_shift(adev, cursor.level - 1);
                if (adev->asic_type < CHIP_VEGA10) {
@@ -1703,9 +1692,8 @@ static int amdgpu_vm_update_ptes(struct amdgpu_pte_update_params *params,
                } while (frag_start < entry_end);
 
                if (amdgpu_vm_pt_descendant(adev, &cursor)) {
-                       /* Mark all child entries as huge */
+                       /* Free all child entries */
                        while (cursor.pfn < frag_start) {
-                               cursor.entry->huge = true;
                                amdgpu_vm_free_pts(adev, params->vm, &cursor);
                                amdgpu_vm_pt_next(adev, &cursor);
                        }
index 116605c038d20bc9fdd079478e75010d21759d5e..3c6537ef659c514e37f6106a61328a4027f8ab2f 100644 (file)
@@ -140,7 +140,6 @@ struct amdgpu_vm_bo_base {
 
 struct amdgpu_vm_pt {
        struct amdgpu_vm_bo_base        base;
-       bool                            huge;
 
        /* array of page tables, one for each directory entry */
        struct amdgpu_vm_pt             *entries;