NFC: digital: Improve a size determination in four functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 22 May 2017 12:11:01 +0000 (14:11 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 22 Jun 2017 22:07:04 +0000 (00:07 +0200)
Replace the specification of four data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
net/nfc/digital_core.c

index ebeace7a8278861939be6eacee410e76b3339430..321514636da173c8f411c393f9543521b2148ee6 100644 (file)
@@ -240,7 +240,7 @@ int digital_send_cmd(struct nfc_digital_dev *ddev, u8 cmd_type,
 {
        struct digital_cmd *cmd;
 
-       cmd = kzalloc(sizeof(struct digital_cmd), GFP_KERNEL);
+       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (!cmd)
                return -ENOMEM;
 
@@ -287,7 +287,7 @@ static int digital_tg_listen_mdaa(struct nfc_digital_dev *ddev, u8 rf_tech)
 {
        struct digital_tg_mdaa_params *params;
 
-       params = kzalloc(sizeof(struct digital_tg_mdaa_params), GFP_KERNEL);
+       params = kzalloc(sizeof(*params), GFP_KERNEL);
        if (!params)
                return -ENOMEM;
 
@@ -706,7 +706,7 @@ static int digital_in_send(struct nfc_dev *nfc_dev, struct nfc_target *target,
        struct digital_data_exch *data_exch;
        int rc;
 
-       data_exch = kzalloc(sizeof(struct digital_data_exch), GFP_KERNEL);
+       data_exch = kzalloc(sizeof(*data_exch), GFP_KERNEL);
        if (!data_exch) {
                pr_err("Failed to allocate data_exch struct\n");
                return -ENOMEM;
@@ -764,7 +764,7 @@ struct nfc_digital_dev *nfc_digital_allocate_device(struct nfc_digital_ops *ops,
            !ops->switch_rf || (ops->tg_listen_md && !ops->tg_get_rf_tech))
                return NULL;
 
-       ddev = kzalloc(sizeof(struct nfc_digital_dev), GFP_KERNEL);
+       ddev = kzalloc(sizeof(*ddev), GFP_KERNEL);
        if (!ddev)
                return NULL;