staging: vc04_services: Prefer WARN_ON_ONCE instead of if condition followed by BUG.
authorKishore KP <kishore.p@techveda.org>
Sun, 24 Dec 2017 14:03:54 +0000 (19:33 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Jan 2018 15:41:37 +0000 (16:41 +0100)
Coccinelle suggested to use BUG_ON instead of if condition followed by BUG
but BUG_ON should be used in situations where integrity of the system is no
longer guaranteed. In this case, as suggested by Stefan Wahren, vchiq isn't
critical.
Since it is not critical, BUG_ON should be avoided.
Replaced if condition followed by BUG with WARN_ON_ONCE.

Signed-off-by: Kishore KP <kishore.p@techveda.org>
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c

index 315b49c1de3bb323f4383e4ba8acb3e3ded422b1..f20cf889e34110f6e2cb1ab20cf7120fcffa3c94 100644 (file)
@@ -224,8 +224,7 @@ vchiq_platform_get_arm_state(VCHIQ_STATE_T *state)
 
        platform_state   = (struct vchiq_2835_state *)state->platform_state;
 
-       if (!platform_state->inited)
-               BUG();
+       WARN_ON_ONCE(!platform_state->inited);
 
        return &platform_state->arm_state;
 }