power: supply: ab8500_fg: fix obsolete function
authorDing Xiang <dingxiang@cmss.chinamobile.com>
Mon, 27 Aug 2018 10:49:15 +0000 (06:49 -0400)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 29 Aug 2018 22:06:45 +0000 (00:06 +0200)
simple_strtoul is obsolete, and use kstrtoint instead

Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/ab8500_fg.c

index 02356f9b5f22a4e89ef74160a8a54e88b117e733..2bdadb58bcc631d0f5fb292e9bf73435b905ba69 100644 (file)
@@ -2582,11 +2582,12 @@ static ssize_t ab8505_powercut_flagtime_write(struct device *dev,
                                  const char *buf, size_t count)
 {
        int ret;
-       long unsigned reg_value;
+       int reg_value;
        struct power_supply *psy = dev_get_drvdata(dev);
        struct ab8500_fg *di = power_supply_get_drvdata(psy);
 
-       reg_value = simple_strtoul(buf, NULL, 10);
+       if (kstrtoint(buf, 10, &reg_value))
+               goto fail;
 
        if (reg_value > 0x7F) {
                dev_err(dev, "Incorrect parameter, echo 0 (1.98s) - 127 (15.625ms) for flagtime\n");
@@ -2636,7 +2637,9 @@ static ssize_t ab8505_powercut_maxtime_write(struct device *dev,
        struct power_supply *psy = dev_get_drvdata(dev);
        struct ab8500_fg *di = power_supply_get_drvdata(psy);
 
-       reg_value = simple_strtoul(buf, NULL, 10);
+       if (kstrtoint(buf, 10, &reg_value))
+               goto fail;
+
        if (reg_value > 0x7F) {
                dev_err(dev, "Incorrect parameter, echo 0 (0.0s) - 127 (1.98s) for maxtime\n");
                goto fail;
@@ -2684,7 +2687,9 @@ static ssize_t ab8505_powercut_restart_write(struct device *dev,
        struct power_supply *psy = dev_get_drvdata(dev);
        struct ab8500_fg *di = power_supply_get_drvdata(psy);
 
-       reg_value = simple_strtoul(buf, NULL, 10);
+       if (kstrtoint(buf, 10, &reg_value))
+               goto fail;
+
        if (reg_value > 0xF) {
                dev_err(dev, "Incorrect parameter, echo 0 - 15 for number of restart\n");
                goto fail;
@@ -2777,7 +2782,9 @@ static ssize_t ab8505_powercut_write(struct device *dev,
        struct power_supply *psy = dev_get_drvdata(dev);
        struct ab8500_fg *di = power_supply_get_drvdata(psy);
 
-       reg_value = simple_strtoul(buf, NULL, 10);
+       if (kstrtoint(buf, 10, &reg_value))
+               goto fail;
+
        if (reg_value > 0x1) {
                dev_err(dev, "Incorrect parameter, echo 0/1 to disable/enable Pcut feature\n");
                goto fail;
@@ -2849,7 +2856,9 @@ static ssize_t ab8505_powercut_debounce_write(struct device *dev,
        struct power_supply *psy = dev_get_drvdata(dev);
        struct ab8500_fg *di = power_supply_get_drvdata(psy);
 
-       reg_value = simple_strtoul(buf, NULL, 10);
+       if (kstrtoint(buf, 10, &reg_value))
+               goto fail;
+
        if (reg_value > 0x7) {
                dev_err(dev, "Incorrect parameter, echo 0 to 7 for debounce setting\n");
                goto fail;