RDMA/efa: Be consistent with success flow return value

The EFA driver is written with success oriented flows in mind, meaning
that functions should mostly end with a return 0 statement.
Error flows return their error value on their own instead of assuming
that the function will return the error at the end.

This commit fixes a bunch of functions that were not aligned with this
behavior.

Reviewed-by: Firas JahJah <firasj@amazon.com>
Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/infiniband/hw/efa/efa_com_cmd.c b/drivers/infiniband/hw/efa/efa_com_cmd.c
index 91e7f2195802d978165d96f82d1b3dbc647dd309..d2464c8390bb43f72f63f2be429eab22c8cbad8b 100644 (file)
--- a/drivers/infiniband/hw/efa/efa_com_cmd.c
+++ b/drivers/infiniband/hw/efa/efa_com_cmd.c
@@ -56,7 +56,7 @@ int efa_com_create_qp(struct efa_com_dev *edev,
        res->send_sub_cq_idx = cmd_completion.send_sub_cq_idx;
        res->recv_sub_cq_idx = cmd_completion.recv_sub_cq_idx;
 
-       return err;
+       return 0;
 }
 
 int efa_com_modify_qp(struct efa_com_dev *edev,
@@ -178,7 +178,7 @@ int efa_com_create_cq(struct efa_com_dev *edev,
        result->cq_idx = cmd_completion.cq_idx;
        result->actual_depth = params->cq_depth;
 
-       return err;
+       return 0;
 }
 
 int efa_com_destroy_cq(struct efa_com_dev *edev,

diff --git a/drivers/infiniband/hw/efa/efa_main.c b/drivers/infiniband/hw/efa/efa_main.c
index 46861461dd2dd38850fe45f93c403f74ab88ce43..dd1c6d49466f5837fa4c33f1cf368e7cfdc77277 100644 (file)
--- a/drivers/infiniband/hw/efa/efa_main.c
+++ b/drivers/infiniband/hw/efa/efa_main.c
@@ -100,7 +100,7 @@ static int efa_request_mgmnt_irq(struct efa_dev *dev)
                nr_cpumask_bits, &irq->affinity_hint_mask, irq->vector);
        irq_set_affinity_hint(irq->vector, &irq->affinity_hint_mask);
 
-       return err;
+       return 0;
 }
 
 static void efa_setup_mgmnt_irq(struct efa_dev *dev)

diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
index f187f1acdb55755ecaec3485f3c52187db490959..7b4e0fa998175f5e22920ed297600258cc5163b7 100644 (file)
--- a/drivers/infiniband/hw/efa/efa_verbs.c
+++ b/drivers/infiniband/hw/efa/efa_verbs.c
@@ -1594,13 +1594,15 @@ static int __efa_mmap(struct efa_dev *dev, struct efa_ucontext *ucontext,
                err = -EINVAL;
        }
 
-       if (err)
+       if (err) {
                ibdev_dbg(
                        &dev->ibdev,
                        "Couldn't mmap address[%#llx] length[%#llx] mmap_flag[%d] err[%d]\n",
                        entry->address, length, entry->mmap_flag, err);
+               return err;
+       }
 
-       return err;
+       return 0;
 }
 
 int efa_mmap(struct ib_ucontext *ibucontext,