drm/amdkfd: Delete a useless parameter from create_queue function pointer

Signed-off-by: Yong Zhao <yong.zhao@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index 8447810c9a1e8024131c6f38570e7a7d32987c60..81ec7bb89b04ce88317b147d7cf59ac017ff8880 100644 (file)
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -149,8 +149,7 @@ static void deallocate_vmid(struct device_queue_manager *dqm,
 
 static int create_queue_nocpsch(struct device_queue_manager *dqm,
                                struct queue *q,
-                               struct qcm_process_device *qpd,
-                               int *allocated_vmid)
+                               struct qcm_process_device *qpd)
 {
        int retval;
 
@@ -170,7 +169,6 @@ static int create_queue_nocpsch(struct device_queue_manager *dqm,
                if (retval)
                        goto out_unlock;
        }
-       *allocated_vmid = qpd->vmid;
        q->properties.vmid = qpd->vmid;
 
        q->properties.tba_addr = qpd->tba_addr;
@@ -184,10 +182,8 @@ static int create_queue_nocpsch(struct device_queue_manager *dqm,
                retval = -EINVAL;
 
        if (retval) {
-               if (list_empty(&qpd->queues_list)) {
+               if (list_empty(&qpd->queues_list))
                        deallocate_vmid(dqm, qpd, q);
-                       *allocated_vmid = 0;
-               }
                goto out_unlock;
        }
 
@@ -812,16 +808,13 @@ static void destroy_kernel_queue_cpsch(struct device_queue_manager *dqm,
 }
 
 static int create_queue_cpsch(struct device_queue_manager *dqm, struct queue *q,
-                       struct qcm_process_device *qpd, int *allocate_vmid)
+                       struct qcm_process_device *qpd)
 {
        int retval;
        struct mqd_manager *mqd;
 
        retval = 0;
 
-       if (allocate_vmid)
-               *allocate_vmid = 0;
-
        mutex_lock(&dqm->lock);
 
        if (dqm->total_queue_count >= max_num_of_queues_per_device) {

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h
index 8752edf9cd9b3d11c48c4c9c05aadbb1fea43b93..c61b693bfa8c3a6aac0af58e5c45bff4d9a3cc42 100644 (file)
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h
@@ -84,8 +84,7 @@ struct device_process_node {
 struct device_queue_manager_ops {
        int     (*create_queue)(struct device_queue_manager *dqm,
                                struct queue *q,
-                               struct qcm_process_device *qpd,
-                               int *allocate_vmid);
+                               struct qcm_process_device *qpd);
 
        int     (*destroy_queue)(struct device_queue_manager *dqm,
                                struct qcm_process_device *qpd,

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
index eeb7726b62991b533e7703427fc673fdcb2a2151..fbfa2741e2a786af678a62601078e18506708884 100644 (file)
--- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
@@ -201,8 +201,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
                        goto err_create_queue;
                pqn->q = q;
                pqn->kq = NULL;
-               retval = dev->dqm->ops.create_queue(dev->dqm, q, &pdd->qpd,
-                                               &q->properties.vmid);
+               retval = dev->dqm->ops.create_queue(dev->dqm, q, &pdd->qpd);
                pr_debug("DQM returned %d for create_queue\n", retval);
                print_queue(q);
                break;
@@ -222,8 +221,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
                        goto err_create_queue;
                pqn->q = q;
                pqn->kq = NULL;
-               retval = dev->dqm->ops.create_queue(dev->dqm, q, &pdd->qpd,
-                                               &q->properties.vmid);
+               retval = dev->dqm->ops.create_queue(dev->dqm, q, &pdd->qpd);
                pr_debug("DQM returned %d for create_queue\n", retval);
                print_queue(q);
                break;