perf symbols: Rename ->ignore to ->idle
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 30 Aug 2016 14:15:59 +0000 (11:15 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 30 Aug 2016 14:15:59 +0000 (11:15 -0300)
Since this is the only use thus far, and this mechanism is in place for
a long time. To clarify why symbols should be skipped or treated
differently, name it for the only use it has.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-oqpf82x2svir611ry15paufd@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c
tools/perf/util/evsel_fprintf.c
tools/perf/util/symbol.h

index e8ca8dc88af93cc0e063294bfa50d0e6f1f69e6e..e0919006fcbaf65457f4de19c319a8fdd6499a20 100644 (file)
@@ -680,7 +680,7 @@ static int symbol_filter(struct map *map, struct symbol *sym)
                return 1;
 
        if (symbol__is_idle(sym))
-               sym->ignore = true;
+               sym->idle = 1;
 
        return 0;
 }
@@ -783,7 +783,7 @@ static void perf_event__process_sample(struct perf_tool *tool,
                }
        }
 
-       if (al.sym == NULL || !al.sym->ignore) {
+       if (al.sym == NULL || !al.sym->idle) {
                struct hists *hists = evsel__hists(evsel);
                struct hist_entry_iter iter = {
                        .evsel          = evsel,
index 3674e77ad64049dddf34e99674d72eaa77792a30..9111e0666950dd535e2f4d8cf1df9fbefe145204 100644 (file)
@@ -122,7 +122,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
                        if (!node)
                                break;
 
-                       if (node->sym && node->sym->ignore)
+                       if (node->sym && node->sym->idle)
                                goto next;
 
                        printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
@@ -181,7 +181,7 @@ int sample__fprintf_sym(struct perf_sample *sample, struct addr_location *al,
        if (cursor != NULL) {
                printed += sample__fprintf_callchain(sample, left_alignment,
                                                     print_opts, cursor, fp);
-       } else if (!(al->sym && al->sym->ignore)) {
+       } else if (!(al->sym && al->sym->idle)) {
                printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
 
                if (print_ip)
index f6c54d3756da44705bd8317701dfc93ff94e5c2f..e54ee7c78ca329aaf41ee21ddb00380aa44a9fca 100644 (file)
@@ -57,7 +57,7 @@ struct symbol {
        u64             end;
        u16             namelen;
        u8              binding;
-       bool            ignore;
+       u8              idle:1;
        u8              arch_sym;
        char            name[0];
 };