staging: rts5208: rename SG_END macro
authorArnd Bergmann <arnd@arndb.de>
Thu, 1 Mar 2018 10:31:29 +0000 (11:31 +0100)
committerJens Axboe <axboe@kernel.dk>
Thu, 1 Mar 2018 15:33:06 +0000 (08:33 -0700)
A change to the generic scatterlist code caused a conflict with
the rtsx card reader driver:

In file included from drivers/staging/rts5208/rtsx.h:180,
                 from drivers/staging/rts5208/rtsx.c:28:
drivers/staging/rts5208/rtsx_chip.h:343: error: "SG_END" redefined [-Werror]

This changes one instance of the driver to prefix SG_END and
related constants.

Fixes: 723fbf563a6a ("lib/scatterlist: Add SG_CHAIN and SG_END macros for LSB encodings")
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/staging/rts5208/rtsx_chip.h
drivers/staging/rts5208/rtsx_transport.c

index 4f6e3c1c4621618c93005e8dd5a8d05541ae3fd7..8a8cd5d3cf7e26f27160450f88d7282f3cfb85d3 100644 (file)
@@ -339,13 +339,13 @@ struct sense_data_t {
 #define CHK_BIT(data, idx)     ((data) & (1 << (idx)))
 
 /* SG descriptor */
-#define SG_INT                 0x04
-#define SG_END                 0x02
-#define SG_VALID               0x01
+#define RTSX_SG_INT            0x04
+#define RTSX_SG_END            0x02
+#define RTSX_SG_VALID          0x01
 
-#define SG_NO_OP               0x00
-#define SG_TRANS_DATA          (0x02 << 4)
-#define SG_LINK_DESC           (0x03 << 4)
+#define RTSX_SG_NO_OP          0x00
+#define RTSX_SG_TRANS_DATA     (0x02 << 4)
+#define RTSX_SG_LINK_DESC      (0x03 << 4)
 
 struct rtsx_chip;
 
index 8b57e17ee6d3bed71f72d2e8eca9dd3a2530d9aa..716cce2bd7f0f7b01e113ad7d666403435439db9 100644 (file)
@@ -308,7 +308,7 @@ static inline void rtsx_add_sg_tbl(
        do {
                if (len > 0x80000) {
                        temp_len = 0x80000;
-                       temp_opt = option & (~SG_END);
+                       temp_opt = option & (~RTSX_SG_END);
                } else {
                        temp_len = len;
                        temp_opt = option;
@@ -407,9 +407,9 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
                        *index = *index + 1;
                }
                if ((i == (sg_cnt - 1)) || !resid)
-                       option = SG_VALID | SG_END | SG_TRANS_DATA;
+                       option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
                else
-                       option = SG_VALID | SG_TRANS_DATA;
+                       option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
 
                rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
 
@@ -555,9 +555,9 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
                                (unsigned int)addr, len);
 
                        if (j == (sg_cnt - 1))
-                               option = SG_VALID | SG_END | SG_TRANS_DATA;
+                               option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
                        else
-                               option = SG_VALID | SG_TRANS_DATA;
+                               option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
 
                        rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);