lib/mpi: mpi_read_raw_from_sgl(): replace len argument by nbytes

Currently, the nbytes local variable is calculated from the len argument
as follows:

  ... mpi_read_raw_from_sgl(..., unsigned int len)
  {
    unsigned nbytes;
    ...
    if (!ents)
      nbytes = 0;
    else
      nbytes = len - lzeros;
    ...
  }

Given that nbytes is derived from len in a trivial way and that the len
argument is shadowed by a local len variable in several loops, this is just
confusing.

Rename the len argument to nbytes and get rid of the nbytes local variable.
Do the nbytes calculation in place.

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
index d995a4c0f1b6833f5696393ac5f4e6f378bffaea..048f0aa505cedc2bdb49eafea79b9629fda4b048 100644 (file)
--- a/lib/mpi/mpicoder.c
+++ b/lib/mpi/mpicoder.c
@@ -418,15 +418,15 @@ EXPORT_SYMBOL_GPL(mpi_write_to_sgl);
  * a new MPI and reads the content of the sgl to the MPI.
  *
  * @sgl:       scatterlist to read from
- * @len:       number of bytes to read
+ * @nbytes:    number of bytes to read
  *
  * Return:     Pointer to a new MPI or NULL on error
  */
-MPI mpi_read_raw_from_sgl(struct scatterlist *sgl, unsigned int len)
+MPI mpi_read_raw_from_sgl(struct scatterlist *sgl, unsigned int nbytes)
 {
        struct scatterlist *sg;
        int x, i, j, z, lzeros, ents;
-       unsigned int nbits, nlimbs, nbytes;
+       unsigned int nbits, nlimbs;
        mpi_limb_t a;
        MPI val = NULL;
 
@@ -455,7 +455,7 @@ MPI mpi_read_raw_from_sgl(struct scatterlist *sgl, unsigned int len)
        if (!ents)
                nbytes = 0;
        else
-               nbytes = len - lzeros;
+               nbytes -= lzeros;
 
        nbits = nbytes * 8;
        if (nbits > MAX_EXTERN_MPI_BITS) {