IB/rxe: fix for duplicate request processing and ack psns

Don't reset the resp opcode for a replayed read response.
The resp opcode could be in the middle of a write or send
sequence, when the duplicate read request was received.
An example sequence is as follows:
- Receive read request for 12KB PSN 20. Transmit read response
  first, middle and last with PSNs 20,21,22.
- Receive write first PSN 23.
  At this point the resp psn is 24 and resp opcode is write first.
- The sender notices that PSN 20 is dropped and retransmits.
  Receive read request for 12KB PSN 20. Transmit read response
  first, middle and last with PSNs 20,21,22. The resp opcode is
  set to -1, the resp psn remains 24.
- Receive write first PSN 23. This is processed by duplicate_request().
  The resp opcode remains -1 and resp psn remains 24.
- Receive write middle PSN 24. check_op_seq() reports a missing
  first error since the resp opcode is -1.

When sending an ack for a duplicate send or write request,
use the psn of the previous ack sent. Do not use the psn
of a read response for the ack.
An example sequence is as follows:
- Receive write PSN 30. Transmit ACK for PSN 30.
- Receive read request 4KB PSN 31. Transmit read response with
  PSN 31. The resp psn is now 32.
- The sender notices that PSN 30 is dropped and retransmits.
  Receive write PSN 30. duplicate_request() sends an ACK with
  PSN 31. That is incorrect since PSN 31 was a read request.

Signed-off-by: Vijay Immanuel <vijayi@attalasystems.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c
index c1948d406528675561224475028d1a0c5f85eb33..c962160292f492a9bea24ae98c50ec9d5fdd258d 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_resp.c
+++ b/drivers/infiniband/sw/rxe/rxe_resp.c
@@ -682,6 +682,7 @@ static enum resp_states read_reply(struct rxe_qp *qp,
                rxe_advance_resp_resource(qp);
 
                res->type               = RXE_READ_MASK;
+               res->replay             = 0;
 
                res->read.va            = qp->resp.va;
                res->read.va_org        = qp->resp.va;
@@ -752,7 +753,8 @@ static enum resp_states read_reply(struct rxe_qp *qp,
                state = RESPST_DONE;
        } else {
                qp->resp.res = NULL;
-               qp->resp.opcode = -1;
+               if (!res->replay)
+                       qp->resp.opcode = -1;
                if (psn_compare(res->cur_psn, qp->resp.psn) >= 0)
                        qp->resp.psn = res->cur_psn;
                state = RESPST_CLEANUP;
@@ -814,6 +816,7 @@ static enum resp_states execute(struct rxe_qp *qp, struct rxe_pkt_info *pkt)
 
        /* next expected psn, read handles this separately */
        qp->resp.psn = (pkt->psn + 1) & BTH_PSN_MASK;
+       qp->resp.ack_psn = qp->resp.psn;
 
        qp->resp.opcode = pkt->opcode;
        qp->resp.status = IB_WC_SUCCESS;
@@ -1065,7 +1068,7 @@ static enum resp_states duplicate_request(struct rxe_qp *qp,
                                          struct rxe_pkt_info *pkt)
 {
        enum resp_states rc;
-       u32 prev_psn = (qp->resp.psn - 1) & BTH_PSN_MASK;
+       u32 prev_psn = (qp->resp.ack_psn - 1) & BTH_PSN_MASK;
 
        if (pkt->mask & RXE_SEND_MASK ||
            pkt->mask & RXE_WRITE_MASK) {
@@ -1108,6 +1111,7 @@ static enum resp_states duplicate_request(struct rxe_qp *qp,
                        res->state = (pkt->psn == res->first_psn) ?
                                        rdatm_res_state_new :
                                        rdatm_res_state_replay;
+                       res->replay = 1;
 
                        /* Reset the resource, except length. */
                        res->read.va_org = iova;

diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index 0d920087811a0ffaa8e14a24b703fc9a2ccd0655..979e987e3c4640f686b14e7927caba8ed1fb872f 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -171,6 +171,7 @@ enum rdatm_res_state {
 
 struct resp_res {
        int                     type;
+       int                     replay;
        u32                     first_psn;
        u32                     last_psn;
        u32                     cur_psn;
@@ -195,6 +196,7 @@ struct rxe_resp_info {
        enum rxe_qp_state       state;
        u32                     msn;
        u32                     psn;
+       u32                     ack_psn;
        int                     opcode;
        int                     drop_msg;
        int                     goto_error;