scsi: aacraid: fix a signedness bug
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 27 Aug 2018 09:23:01 +0000 (12:23 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 27 Aug 2018 17:17:00 +0000 (13:17 -0400)
The problem is that ->reset_state is a u8 but it can be set to -1 or -2 in
aac_tmf_callback() and the error handling in aac_eh_target_reset() relies
on it to be signed.

[mkp: fixed typo]

Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aacraid/aacraid.h

index 29bf1e60f5428ab4542cf0bd838342bd8d405f8b..39eb415987fc9fd901ba9ee157dedfcf76910829 100644 (file)
@@ -1346,7 +1346,7 @@ struct fib {
 struct aac_hba_map_info {
        __le32  rmw_nexus;              /* nexus for native HBA devices */
        u8              devtype;        /* device type */
-       u8              reset_state;    /* 0 - no reset, 1..x - */
+       s8              reset_state;    /* 0 - no reset, 1..x - */
                                        /* after xth TM LUN reset */
        u16             qd_limit;
        u32             scan_counter;