rtc: diasemi: stop validating rtc_time in .read_time
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 2 Mar 2018 09:08:47 +0000 (10:08 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 2 Mar 2018 09:11:02 +0000 (10:11 +0100)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it before returning from the callback.

Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-da9052.c
drivers/rtc/rtc-da9055.c
drivers/rtc/rtc-da9063.c

index 4273377562ec64dcdf640506fe4b4dd83b413de0..03044e1bc4974ff7e28957413dc4a8d99a0e95ef 100644 (file)
@@ -187,8 +187,7 @@ static int da9052_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm)
                        rtc_tm->tm_min  = v[0][1] & DA9052_RTC_MIN;
                        rtc_tm->tm_sec  = v[0][0] & DA9052_RTC_SEC;
 
-                       ret = rtc_valid_tm(rtc_tm);
-                       return ret;
+                       return 0;
                }
 
                idx = (1-idx);
index 678af8648c45316f22ec7e4d124d1758436022d6..e08cd8130c23013b3d7ab2586b638bc5434c0dce 100644 (file)
@@ -158,7 +158,7 @@ static int da9055_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm)
        rtc_tm->tm_min  = v[1] & DA9055_RTC_MIN;
        rtc_tm->tm_sec  = v[0] & DA9055_RTC_SEC;
 
-       return rtc_valid_tm(rtc_tm);
+       return 0;
 }
 
 static int da9055_rtc_set_time(struct device *dev, struct rtc_time *tm)
index f85cae240f123eafde246ba1c084c8b6943d171e..b4e054c64bad9e54d23adb3a47da1008224906b3 100644 (file)
@@ -256,7 +256,7 @@ static int da9063_rtc_read_time(struct device *dev, struct rtc_time *tm)
        else
                rtc->rtc_sync = false;
 
-       return rtc_valid_tm(tm);
+       return 0;
 }
 
 static int da9063_rtc_set_time(struct device *dev, struct rtc_time *tm)